misc: rename LHError to LighthouseError #14173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@connorjclark we For ESM in general, it might be helpful if you start tagging issues with an |
adamraine
approved these changes
Jun 30, 2022
|
@benschwarz you should just look through #12689, anything related to esm is linked there. 10.0 will be the first release to transition the node API to esm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While converting core to ESM (ref #12689) I changed
lh-error.jsto export theLighthouseErrorclass as a named property. It's odd to export a class under a different name (LHError), so I've updated all usages of LHError to LighthouseError. This PR is to make the upcoming core PR slightly less big.Potentially breaking is the change of
name. Could revert if someone feels strongly about it.Of course, an alternative is to rename the class to
LHError. No strong preference, just leaning towards spelling out our classes as a default.