Skip to content

misc: fix broken links in changelog #14130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged

misc: fix broken links in changelog #14130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build/changelog-generator/templates/header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
<a name="{{version}}"></a>
# {{version}} ({{date}})
{{#if @root.linkCompare~}}
[Full Changelog]({{~@root.repoUrl}}/compare/{{previousTag}}...{{currentTag}})
[Full Changelog](
{{~#if @root.host}}{{~@root.host}}/{{/if~}}
{{~#if @root.owner ~}}{{@root.owner}}/{{/if~}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do all these newlines work? yarn changelog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked fine when I tried it:

 <a name="9.5.0"></a>
# 9.5.0 (2022-06-15)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v7.3.0...v9.5.0)

~~ TODO: https://chromiumdash.appspot.com/schedule ~~
We expect this release to ship in the DevTools of [Chrome XX](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.

## Notable Changes
~~ TODO: Move notable changes here ~~


## New Audits

* add work-during-interaction diagnostic ([#13982](https://github.com/GoogleChrome/lighthouse/pull/13982))
* add responsiveness metric for timespans ([#13917](https://github.com/GoogleChrome/lighthouse/pull/13917))
* lcp-lazy-loaded ([#12838](https://github.com/GoogleChrome/lighthouse/pull/12838))
* fr: uses-responsive-images-snapshot ([#12714](https://github.com/GoogleChrome/lighthouse/pull/12714))

{{~@root.repository}}/compare/{{previousTag}}...{{currentTag}})
{{~/if}}


Expand Down
8 changes: 4 additions & 4 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<a name="9.5.0"></a>
# 9.5.0 (2022-03-09)
[Full Changelog](https://github.com/compare/v9.4.0...v9.5.0)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.4.0...v9.5.0)

We expect this release to ship in the DevTools of [Chrome 101](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.

Expand Down Expand Up @@ -54,7 +54,7 @@ Thanks to our new contributor 👽🐷🐰🐯🐻!

<a name="9.4.0"></a>
# 9.4.0 (2022-02-16)
[Full Changelog](https://github.com/compare/v9.3.1...v9.4.0)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.1...v9.4.0)

We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.

Expand Down Expand Up @@ -99,15 +99,15 @@ We expect this release to ship in the DevTools of [Chrome 100](https://chromiumd

<a name="9.3.1"></a>
# 9.3.1 (2022-01-31)
[Full Changelog](https://github.com/compare/v9.3.0...v9.3.1)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.0...v9.3.1)

## Report

* disable fireworks with flag ([#13610](https://github.com/GoogleChrome/lighthouse/pull/13610))

<a name="9.3.0"></a>
# 9.3.0 (2022-01-31)
[Full Changelog](https://github.com/compare/v9.2.0...v9.3.0)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.2.0...v9.3.0)

We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.

Expand Down