i18n: replace placeholder using replacer callback #14109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from chat:
replacing strings literally in JS is actually pretty not straightforward. Worse, it will work in like 99% of cases until it doesn't. See:
this prints Dollar: '); ... note the missing dollar sign ... because the replace function is "regex-aware" even if the first parameter is not a regex ...
only valid for$' and $ `. the others ($0, $1) don't work
so you must do this:
After auditing all our usages of
String.prototype.replace
, I only found this one instance where it could theoretically be problematic.