core(driver): guard verbose logic behind log.isVerbose check #14086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 4, 2022
| @@ -164,7 +164,8 @@ function waitForNetworkIdle(session, networkMonitor, networkQuietOptions) { | |||
| const inflightRecords = networkMonitor.getInflightRequests(); | |||
| // If there are more than 20 inflight requests, load is still in full swing. | |||
| // Wait until it calms down a bit to be a little less spammy. | |||
| if (inflightRecords.length < 20) { | |||
| if (log.isVerbose() && inflightRecords.length < 20 && inflightRecords.length > 0) { | |||
| log.verbose('waitFor', `=== Waiting on ${inflightRecords.length} requests to finish`); | |||
There was a problem hiding this comment.
this made the logs easier to read for me
paulirish
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a lot of logging on network events when there is <20 inflight. This can be a lot of string operations that are just done for naught if the logging isn't verbose. so I added a simple check to avoid that.