tests(smoke): increase windows retries #14022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what changed? can you add a comment or something with your repro setup in case someone else has to down the same rabbithole? good news, regardless. :) |
I was testing with Chrome Stable originally, and I had another non-testing Chrome window open for normal use and stuff. Having that window open appears to prevent the issues from popping up. When I closed all Chrome windows before running the smokes I started seeing the failures again. |
e2c84cd to
1a71fe9
Compare
connorjclark
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went out of my way to get a windows cloudtop, and reproduced our windows smoke failures on that, but it only happened the first time. I can't repro anymore 🙃I can consistently repro the CI failures on the windows cloudtop.
Theoretically, a bump in the retries will do the same for CI though so let's see what happens...