misc: use top-level await #13975
Merged
misc: use top-level await #13975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Raine <[email protected]>
connorjclark
commented
May 6, 2022
| @@ -26,8 +26,7 @@ if (!process.env.WPT_KEY) throw new Error('missing WPT_KEY'); | |||
| const WPT_KEY = process.env.WPT_KEY; | |||
| const DEBUG = process.env.DEBUG; | |||
|
|
|||
| /** @type {typeof common.ProgressLogger['prototype']} */ | |||
| let log; | |||
| const log = new common.ProgressLogger(); | |||
happens in Node 15, sry :/ |
|
hmm, was it perhaps backported?
|
|
anyway, we could add |
|
checked our min node version 14.15 and also OK
@brendankenny I think that top-level awaited promises are not unconsidered "unhandled" on rejections. The runtime is handling them. |
adamraine
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#13967 should land first)
Fixes #13964
I likely missed a few places where we could use top-level await.
FYI:
I verified that a node process exits with 1 and logs the error when a promise rejects, so no need to catch them.