core(config): use fr config to construct the legacy config #13965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe that should happen in one PR? Presumably that would preserve more blame since a lot of things (like UIStrings) would be unchanged |
Hmm yeah, also looks like the id for all the UI strings gets updated so I will try that. |
This reverts commit da5ddbc.
adamraine
commented
May 4, 2022
connorjclark
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
LGTM
In a follow-up PR I am planning to remove the fraggle-rock/ config folder and replace it with a legacy one.
Should do this first: #14105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the fr default config was just the legacy default config with a few modifications. This PR just reverses the relationship so the new default will be all in one file. The FR config now lives in
default-config.jsand the legacy config lives inlegacy-default-config.js.In a follow-up PR I am planning to remove the
fraggle-rock/config folder and replace it with alegacyone.