GoogleChrome · devtools-bot · May 6, 2022 · May 4, 2022 · May 5, 2022 · May 6, 2022
diff --git a/build/test/plugins/.eslintrc.cjs b/build/test/plugins/.eslintrc.cjs
@@ -0,0 +1,11 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+module.exports = {
+  env: {
+    jest: true,
+  },
+};
diff --git a/build/test/plugins/inline-fs-test.js b/build/test/plugins/inline-fs-test.js
@@ -4,9 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-
-/* eslint-env jest */
-
 import fs from 'fs';
 import path from 'path';
 

diff --git a/clients/test/.eslintrc.cjs b/clients/test/.eslintrc.cjs
@@ -0,0 +1,11 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+module.exports = {
+  env: {
+    jest: true,
+  },
+};
diff --git a/clients/test/extension/popup-test-pptr.js b/clients/test/extension/popup-test-pptr.js
@@ -5,8 +5,6 @@
  */
 'use strict';
 
-/* eslint-env jest */
-
 const path = require('path');
 const puppeteer = require('puppeteer-core');
 const {getChromePath} = require('chrome-launcher');

diff --git a/clients/test/extension/settings-controller-test.js b/clients/test/extension/settings-controller-test.js
@@ -5,8 +5,6 @@
  */
 'use strict';
 
-/* eslint-env jest */
-
 const SettingsController = require('../../extension/scripts/settings-controller.js');
 const defaultConfig = require('../../../lighthouse-core/config/default-config.js');
 const format = require('../../../shared/localization/format.js');

diff --git a/clients/test/lightrider/lightrider-entry-test.js b/clients/test/lightrider/lightrider-entry-test.js
@@ -11,8 +11,6 @@ import {runLighthouseInLR} from '../../lightrider/lightrider-entry.js';
 import Runner from '../../../lighthouse-core/runner.js';
 import LHError from '../../../lighthouse-core/lib/lh-error.js';
 
-/* eslint-env jest */
-
 describe('lightrider-entry', () => {
   describe('#runLighthouseInLR', () => {
     it('returns a runtimeError LHR when lighthouse throws a runtimeError', async () => {

diff --git a/docs/recipes/integration-test/.eslintrc.cjs b/docs/recipes/integration-test/.eslintrc.cjs
@@ -0,0 +1,11 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+module.exports = {
+  env: {
+    jest: true,
+  },
+};
diff --git a/docs/recipes/integration-test/example-lh-auth.test.js b/docs/recipes/integration-test/example-lh-auth.test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 'use strict';
-
-/* eslint-env jest */
 /* eslint-disable new-cap */
 
 /**

diff --git a/lighthouse-cli/test/.eslintrc.cjs b/lighthouse-cli/test/.eslintrc.cjs
@@ -0,0 +1,11 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+module.exports = {
+  env: {
+    jest: true,
+  },
+};
diff --git a/lighthouse-cli/test/cli/bin-test.js b/lighthouse-cli/test/cli/bin-test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-/* eslint-env jest */
-
 import fs from 'fs';
 
 import {jest} from '@jest/globals';

diff --git a/lighthouse-cli/test/cli/cli-flags-test.js b/lighthouse-cli/test/cli/cli-flags-test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-/* eslint-env jest */
-
 import {strict as assert} from 'assert';
 import fs from 'fs';
 

diff --git a/lighthouse-cli/test/cli/index-test.js b/lighthouse-cli/test/cli/index-test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-/* eslint-env jest */
-
 import {strict as assert} from 'assert';
 import {spawnSync} from 'child_process';
 

diff --git a/lighthouse-cli/test/cli/printer-test.js b/lighthouse-cli/test/cli/printer-test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-/* eslint-env jest */
-
 import {strict as assert} from 'assert';
 import fs from 'fs';
 

diff --git a/lighthouse-cli/test/cli/run-test.js b/lighthouse-cli/test/cli/run-test.js
@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-/* eslint-env jest */
-
 import {strict as assert} from 'assert';
 import path from 'path';
 import fs from 'fs';

diff --git a/lighthouse-cli/test/fixtures/static-server-test.js b/lighthouse-cli/test/fixtures/static-server-test.js
@@ -10,7 +10,6 @@ import fetch from 'node-fetch';
 
 import {server} from './static-server.js';
 
-/* eslint-env jest */
 
 describe('Server', () => {
   beforeAll(async () => {

diff --git a/lighthouse-cli/test/smokehouse/version-check-test.js b/lighthouse-cli/test/smokehouse/version-check-test.js
@@ -6,8 +6,6 @@
 
 import {chromiumVersionCheck, compareVersions} from './version-check.js';
 
-/* eslint-env jest */
-
 describe('version check', () => {
   it('compareVersions', async () => {
     expect(compareVersions([100, 0, 0, 0], [100, 0, 0, 0])).toBe(0);

diff --git a/lighthouse-core/test/.eslintrc.cjs b/lighthouse-core/test/.eslintrc.cjs
@@ -5,6 +5,9 @@
  */
 
 module.exports = {
+  env: {
+    jest: true,
+  },
   rules: {
     // TODO(esmodules): move to root eslint when all code is ESM
     // or when this is resolved: https://github.com/import-js/eslint-plugin-import/issues/2214

diff --git a/lighthouse-core/test/audits/accessibility/aria-allowed-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-allowed-attr-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-allowed-attr.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-allowed-attr audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-required-attr-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-required-attr.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-required-attr audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-children-test.js b/lighthouse-core/test/audits/accessibility/aria-required-children-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-required-children.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-required-children audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-parent-test.js b/lighthouse-core/test/audits/accessibility/aria-required-parent-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-required-parent.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-required-parent audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-roles-test.js b/lighthouse-core/test/audits/accessibility/aria-roles-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-roles.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-roles audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-valid-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-valid-attr-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-valid-attr.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-valid-attr audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/aria-valid-attr-value-test.js b/lighthouse-core/test/audits/accessibility/aria-valid-attr-value-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/aria-valid-attr-value.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: aria-valid-attr-value audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/axe-audit-test.js b/lighthouse-core/test/audits/accessibility/axe-audit-test.js
@@ -13,8 +13,6 @@ import AxeAudit from '../../../audits/accessibility/axe-audit.js';
 import Accesskeys from '../../../audits/accessibility/accesskeys.js';
 import format from '../../../../shared/localization/format.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: axe-audit', () => {
   describe('audit()', () => {
     it('generates audit output using subclass meta', () => {

diff --git a/lighthouse-core/test/audits/accessibility/button-name-test.js b/lighthouse-core/test/audits/accessibility/button-name-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/button-name.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: button-name audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/bypass-test.js b/lighthouse-core/test/audits/accessibility/bypass-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/bypass.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: bypass audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/color-contrast-test.js b/lighthouse-core/test/audits/accessibility/color-contrast-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/color-contrast.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: color-contrast audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/definition-list-test.js b/lighthouse-core/test/audits/accessibility/definition-list-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/definition-list.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: definition-list audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/dlitem-test.js b/lighthouse-core/test/audits/accessibility/dlitem-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/dlitem.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: dlitem audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/document-title-test.js b/lighthouse-core/test/audits/accessibility/document-title-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/document-title.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: document-title audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/frame-title-test.js b/lighthouse-core/test/audits/accessibility/frame-title-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/frame-title.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: frame-title audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/html-has-lang-test.js b/lighthouse-core/test/audits/accessibility/html-has-lang-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/html-has-lang.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: html-has-lang audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/html-lang-valid-test.js b/lighthouse-core/test/audits/accessibility/html-lang-valid-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/html-lang-valid.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: html-lang-valid audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/image-alt-test.js b/lighthouse-core/test/audits/accessibility/image-alt-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/image-alt.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: image-alt audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/input-image-alt-test.js b/lighthouse-core/test/audits/accessibility/input-image-alt-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/input-image-alt.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: input-image-alt audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/label-test.js b/lighthouse-core/test/audits/accessibility/label-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/label.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: label audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/link-name-test.js b/lighthouse-core/test/audits/accessibility/link-name-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/link-name.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: link-name audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/list-test.js b/lighthouse-core/test/audits/accessibility/list-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/list.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: list audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/listitem-test.js b/lighthouse-core/test/audits/accessibility/listitem-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/listitem.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: listitem audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/meta-refresh-test.js b/lighthouse-core/test/audits/accessibility/meta-refresh-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/meta-refresh.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: meta-refresh audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/meta-viewport-test.js b/lighthouse-core/test/audits/accessibility/meta-viewport-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/meta-viewport.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: meta-viewport audit', () => {
   it('generates an audit output', () => {
     const artifacts = {

diff --git a/lighthouse-core/test/audits/accessibility/object-alt-test.js b/lighthouse-core/test/audits/accessibility/object-alt-test.js
@@ -9,8 +9,6 @@ import {strict as assert} from 'assert';
 
 import Audit from '../../../audits/accessibility/object-alt.js';
 
-/* eslint-env jest */
-
 describe('Accessibility: object-alt audit', () => {
   it('generates an audit output', () => {
     const artifacts = {