docs(recipes): update custom-gatherer-puppeteer to use FR #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,6 @@ | |||
| # Make sure we're in this `docs/recipes/customer-gatherer-puppeteer` directory | |||
| cd "$(dirname "$0")" | |||
|
|
|||
| node node_modules/.bin/lighthouse --legacy-navigation --config-path=custom-config.js https://www.example.com --output=json | | |||
| node node_modules/.bin/lighthouse --config-path=custom-config.js https://www.example.com --output=json | | |||
| jq '.audits["custom-audit"].score' | | |||
There was a problem hiding this comment.
happy to see the recipe tests paying off :)
brendankenny
reviewed
May 5, 2022
adamraine
commented
Aug 24, 2022
510320c to
a36d9d0
Compare
f6593c7 to
b70749e
Compare
connorjclark
reviewed
Sep 6, 2022
cc223da to
b6da8c5
Compare
connorjclark
approved these changes
Sep 7, 2022
adamraine
added a commit
that referenced
this pull request
Oct 10, 2022
adamraine
added a commit
that referenced
this pull request
Oct 20, 2022
adamraine
added a commit
that referenced
this pull request
Nov 15, 2022
adamraine
added a commit
that referenced
this pull request
Dec 12, 2022
adamraine
added a commit
that referenced
this pull request
Jan 25, 2023
adamraine
added a commit
that referenced
this pull request
Feb 3, 2023
adamraine
added a commit
that referenced
this pull request
Feb 3, 2023
adamraine
added a commit
that referenced
this pull request
Feb 4, 2023
adamraine
added a commit
that referenced
this pull request
Feb 7, 2023
adamraine
added a commit
that referenced
this pull request
Feb 7, 2023
adamraine
added a commit
that referenced
this pull request
Feb 8, 2023
adamraine
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #13860 (comment), it wasn't possible to use this example with FR. Fortunately, it's very simple add a
getPagefunction to the FR driver that will work in this example.This can land after #13860