Skip to content

tests: replace $0 in cli-flag snapshots #13922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2022
Merged

tests: replace $0 in cli-flag snapshots #13922

merged 1 commit into from
Apr 27, 2022

Conversation

brendankenny
Copy link
Contributor

fixes #13875

The command to run tests changes depending on how you invoke jest, but is completely irrelevant to cli-flags parsing, so it can just be removed.

@brendankenny brendankenny requested a review from a team as a code owner April 27, 2022 00:00
@brendankenny brendankenny requested review from adamraine and removed request for a team April 27, 2022 00:00
jeje-barbershop
jeje-barbershop reviewed Apr 27, 2022
View reviewed changes
Copy link

@jeje-barbershop jeje-barbershop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendankenny

@devtools-bot devtools-bot merged commit 4ba90ad into master Apr 27, 2022
@devtools-bot devtools-bot deleted the cli-flags-snaps branch April 27, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeje-barbershop jeje-barbershop jeje-barbershop left review comments

@connorjclark connorjclark connorjclark approved these changes

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli-flags snapshots fail depending on how you run them
5 participants
@brendankenny @connorjclark @adamraine @jeje-barbershop @devtools-bot