clients(lr): add FR navigation support #13901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
May 4, 2022
|
setting to draft (until adam confirms smoke tests pass in LR) |
|
I tested and verified that our smokes work as expected* in cl/466510684 * excluding some smokes that were failing on legacy too and some screenshot node ID mismatch BS that #14272 would theoretically fix |
connorjclark
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔒 Doc
The new
useFraggleRockflag can be used to run a FR navigation instead of a legacy navigation. This passes most of our smoke tests, with the exceptions being tests that use_legacyOnlyor_fraggleRockOnly. LR smokes will need to accept the FR option as well.