Skip to content

core(accessibility): link audits directly to axe docs #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

brendankenny
Copy link
Contributor

@brendankenny brendankenny commented Apr 19, 2022

As part of a larger migration of Lighthouse content from web.dev to developer.chrome.com, we're going to be pointing the accessibility audits back to the axe documentation. Those docs are updated in step with the audits themselves and have great examples, etc, so we'll just point users to them directly.

The corresponding web.dev change is GoogleChrome/web.dev#7404, but this is ready to go now while that will have to wait on migrating the manual audit docs (since there are no axe docs for them).

@brendankenny brendankenny requested a review from a team as a code owner April 19, 2022 21:24
@brendankenny brendankenny requested review from connorjclark and removed request for a team April 19, 2022 21:24
@brendankenny
Copy link
Contributor Author

I didn't manually update the locale files since that will be a TC no-op and come back through on the next string roundtrip.

@connorjclark
Copy link
Collaborator

wdyt of adding a test that checks axeVersion (pulled from package.json) exists in these urls, so we don't forget to update them? don't need to check every one, just one would do as a reminder.

@brendankenny
Copy link
Contributor Author

it's not pretty but works for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants