Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer [minor]: macOS keychain item is named after APFS container device node and not after Nix Store APFS volume #990

Open
ink-splatters opened this issue Jun 5, 2024 · 0 comments
Open

Installer [minor]: macOS keychain item is named after APFS container device node and not after Nix Store APFS volume #990

ink-splatters opened this issue Jun 5, 2024 · 0 comments

Comments

@ink-splatters
Copy link

ink-splatters commented Jun 5, 2024 •
edited

Error

I guess this was attempt to name the keychain item after Nix Store device node name, however the item is named after APFS container node instead, which doesn't make too much sense.

keychain-item

In my case it should've been named disk4s5:

/dev/disk4 (synthesized):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      APFS Container Scheme -                      +460.0 GB   disk4
                                 Physical Store disk0s2
   1:                APFS Volume Macintosh HD            10.3 GB    disk4s1
   2:              APFS Snapshot com.apple.os.update-... 10.3 GB    disk4s1s1
   3:                APFS Volume Preboot                 6.3 GB     disk4s2
   4:                APFS Volume Recovery                991.0 MB   disk4s3
   5:                APFS Volume Data                    59.0 GB    disk4s4
   6:                APFS Volume Nix Store               91.4 MB    disk4s5
   7:                APFS Volume Dev                     38.3 GB    disk4s6
   8:                APFS Volume Music                   28.8 GB    disk4s7
   9:                APFS Volume BigSur                  15.1 GB    disk4s8
  10:                APFS Volume BSD                     16.7 GB    disk4s9
  11:                APFS Volume VM                      1.1 GB     disk4s10

ic@airstation /tmp %

Follow official nix installer approach

searching for disk nodes in keychain generally is not very productive. E.g. I use nix encryption script to encrypt unrelated volumes:

image

so why not name the item Nix Store which makes it immediately visible?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ink-splatters