Add CT to DiscordClient#ConnectAsync #2011
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plerx2493
reviewed
Jul 16, 2024
| @@ -36,6 +36,7 @@ private async Task ReceiveGatewayEventsAsync() | |||
| { | |||
| while (!this.eventReader.Completion.IsCompleted) | |||
| { | |||
| // Open question: Do we want to pass a CT here? | |||
There was a problem hiding this comment.
Yes because this loop waits until the next recieved gw event
There was a problem hiding this comment.
The CT is cancelled further up, which should in theory gracefully close the channel, instead of outright aborting it? ChannelClosedException vs OperationCancelledException, I'll have to look at this more closely.
There was a problem hiding this comment.
have you perchance looked at this more closely?
There was a problem hiding this comment.
I can when I'm not 6 hours past my sleep schedule
(also you can't just say perchance)
There was a problem hiding this comment.
It's valid to be thorough and add an extra check if we're not sure. Or- like aki said, double check :))
akiraveliara
approved these changes
Jul 24, 2024
|
Is there any plan to finish this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.