Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: themes.php on Simple should not submit the search #91978

Closed
Copons opened this issue Jun 20, 2024 · 1 comment
Closed

Themes: themes.php on Simple should not submit the search #91978

Copons opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Platform] Simple [Pri] TBD [Type] Bug

Comments

@Copons
Copy link
Contributor

Copons commented Jun 20, 2024

In the themes.php page on untangled Simple sites, there's a search field that filters the list of themes displayed.

The filtering happens on type; submitting the field is not needed.

However, we don't block it. Hitting enter and submitting the form causes the page to reload without search param, returning to the original unfiltered theme list.

On the Core version, the field is prevented from submitting, guarding against this behaviour.

We should do the same on the untangled Simple sites version.

@Copons Copons added [Type] Bug [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Platform] Simple labels Jun 20, 2024
@rcrdortiz
Copy link
Contributor

A fix has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Platform] Simple [Pri] TBD [Type] Bug
Projects
Development

No branches or pull requests

2 participants