Skip to content

[WIP] Azure plugin for the cloud manager #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 36 commits into from
Closed

[WIP] Azure plugin for the cloud manager #771

wants to merge 36 commits into from

Conversation

shiva-kannan
Copy link
Collaborator

@shiva-kannan shiva-kannan commented Aug 28, 2020 •
edited
Loading

Link the Issue(s) this Pull Request is related to.
#772

Summarize your change.
The first draft of the azure plugin implementation for the cloud API.
Current supports :

  1. Listing VM Scale Sets under a particular resource group
  2. A naive implementation of the status field
  3. Resizing a particular scale set
  4. Deleting the scale set from the interface

@shiva-kannan
Initial commit for checking ways to get around the gRPC objects problem
bb59832
@shiva-kannan
Changed the way status and instances are queried
88cc545
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
f31e9c3
@shiva-kannan
First working version of entire GUI flow and all GCE api calls
8915da1
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
1753c8a
@shiva-kannan
Cleanup + Added a way to show current -> target size + gcloud test se…
5d0b10f 
…tup for review
@shiva-kannan
A more descriptive status field
1f8ec28
@shiva-kannan
Fixed copyright, imports and some naming conventions
1b3c8b4
@shiva-kannan
Changed the structure a bit to have a cloud manager abstract class. A…
a63ac77 
…dded google api client library to requirements.txt
@shiva-kannan
Changed the structure of the tests for review. Removed the google pyt…
6fd7e17 
…hon client requirement for now
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
e887da6
@shiva-kannan
Adding google python api client to requirements.txt
c44f97d
@shiva-kannan
Adding oauth2client into requirements
8349710
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
714f169
@shiva-kannan
Added other basics tests for gce_api. moved the connect method out of…
96f46e2 
… the constructor
@shiva-kannan
Added intial exception handling and pop for immediate errors
7b3a0cf
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
c079421
@shiva-kannan
More exception handling, additional tests, alphabetized imports, more…
99ba991 
… doc strings
@shiva-kannan
fixed test bug
a35e268
@shiva-kannan
Merge remote-tracking branch 'upstream/master' into cloudplugin
579447c
@shiva-kannan
Adjusted main api. Separate getter for name attribute
11e9de6
@shiva-kannan
Azure plugin basics
560858a
@shiva-kannan
menu action tests
c693b8a
@shiva-kannan
Yaml config for handling cloud service related setup
d383a8c
@shiva-kannan
Merge remote-tracking branch 'origin/cloudplugin' into azure-plugin
8ae2049
@shiva-kannan
Merge remote-tracking branch 'remotes/upstream/master' into cloudplugin
70232ec
@shiva-kannan
Merge branch 'cloudplugin' into azure-plugin
4f6b9d9
@shiva-kannan
Fixed the connect method for cloud group add dialog
56126ce
@shiva-kannan
Minor bug fix for delete context menu
c919b61
@shiva-kannan
Merge remote-tracking branch 'origin/cloudplugin' into azure-plugin
d506786
@shiva-kannan
Copy link
Collaborator Author

Hey @bcipriano @gregdenton!

AzureCloudGroupCreateFlow

I refactored the creation dialog quite a bit to support multiple providers. This is how it looks as of now. The code needs some refactoring to make it easier to implement future providers but this is a start.
As far as the azure_api goes, I am not sure if I would have to expose parameters like sku , virtual_network and subnets available for that resource group for creating a new VMScaleSet . I have restricted the queries to a single resource group and hardcoded the sku to standard for now.
Azure API wise I have taken a pass at all the calls that the GCE API also could do. Would love some feedback and see if I am approaching this correctly.

@gregdenton gregdenton self-assigned this Jun 23, 2021
@DiegoTavares
Copy link
Collaborator

Closing up stale PRs. I acknowledge this issue is a WIP but it hasn't seen updates for over 3y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano Awaiting requested review from bcipriano bcipriano will be requested when the pull request is marked ready for review bcipriano is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton gregdenton will be requested when the pull request is marked ready for review gregdenton is a code owner

@jrray jrray Awaiting requested review from jrray jrray will be requested when the pull request is marked ready for review jrray is a code owner

@smith1511 smith1511 Awaiting requested review from smith1511 smith1511 will be requested when the pull request is marked ready for review smith1511 is a code owner

@larsbijl larsbijl Awaiting requested review from larsbijl larsbijl will be requested when the pull request is marked ready for review larsbijl is a code owner

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares will be requested when the pull request is marked ready for review DiegoTavares is a code owner

Assignees

@gregdenton gregdenton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiva-kannan @DiegoTavares @gregdenton