Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astcenc outright segfaults in decode mode with these inputs #4

Closed
xorgy opened this issue Jul 13, 2015 · 2 comments
Closed

astcenc outright segfaults in decode mode with these inputs #4

xorgy opened this issue Jul 13, 2015 · 2 comments

Comments

@xorgy
Copy link

xorgy commented Jul 13, 2015 •
edited

I realize that input validation is not currently a priority; however, in case you'd ever like to work on it, I let a fuzzer have its way with astcenc -d for more-or-less twenty hours, and it shook out these 173 address boundary errors, which may be mostly related.

This link refers to a gzipped tarball containing the test cases it found. Each test case is trimmed to the smallest form that still reliably produces the crash.
http://marumie.magnifi.ca/astcenc/crashes.tgz

If any of these are architecture-specific, my test platform was AMD64.

Have a nice morning in Cambridge. :- )
@achary01
Copy link
Contributor

Hi,
thanks for that. We'll have a a look to it.
regards,
Adam

@WolfWings WolfWings mentioned this issue Mar 30, 2017
Merged
@WolfWings
Copy link
Contributor

Pull Request #13 fixes these; they were mostly a matter of zero-dimension values for the overall image size, and overly simplified ASTC-blocksize dimension value checking allowing for a combination of...

*p = malloc(0); // segfault if p is accessed

...and trying to lookup invalid expansions at 7, 9, or 11 X/Y or 2, 7, 8, 9, 10, 11, or 12 Z blocksizes.

@smartether smartether mentioned this issue Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xorgy @WolfWings @achary01