Open
Bug 1834296
Opened 1 year ago
Updated 1 year ago
Debugger still pauses at lines which has disabled breakpoint when opening toolbox on another panel
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox-esr102 affected, firefox113 affected, firefox114 affected, firefox115 affected)
People
(Reporter: nchevobbe, Assigned: bomsy)
Details
Attachments
(2 files)
Steps to reproduce
- Go to https://nchevobbe.github.io/demo/console-test-app.html
- Open the debugger
- In the source tree, select
console-test-event-listeners.js - Add a breakpoint on line 7 (
if (e.target.tagName === "BUTTON") {) - Disable it from the "Breakpoints" panel
- Close DevTools
- Re-open DevTools, but not with the debugger (e.g. use the Inspector, or Console), this is important to reproduce the bug
- Click in the content page
Expected results
The debugger does not pause
Actual results
The debugger pauses, even though the breakpoint on the line is disabled
I'm reproducing with a clean profile
|
Reporter | |
Comment 1•1 year ago
•
|
||
Probably not recent as I was able to reproduce on 102.9.0esr
status-firefox113:
--- → affected
status-firefox114:
--- → affected
status-firefox115:
--- → affected
status-firefox-esr102:
--- → affected
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(hmanilla)
|
|
Assignee | |
Comment 2•1 year ago
|
||
- Renamed the test to be more specific
browser_dbg-breakpoints.jstobrowser_dbg-breakpoints-enable-and-disable.js - Cleanup the test to be simpler and more specific
- Make sure to also t:est the server i.e make sure the disabled breakpoints do not actually get hit
|
||
Updated•1 year ago
|
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D179897
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(hmanilla)
|
||
Updated•1 year ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5427bcae296 [devtools] Cleanup the test for enabling/disabling breakpoints r=devtools-reviewers,ochameau https://hg.mozilla.org/integration/autoland/rev/e16305b72dc9 [devtools] Do not call setBreakpoints for disabled breakpoints on a reconfigure r=ochameau,devtools-reviewers
|
||
Comment 5•1 year ago
•
|
||
Backed out for dt failures on browser_dbg-breakpoints-enable-and-disable.js.
Failure logs:
TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-enable-and-disable.js | Test timed out- https://treeherder.mozilla.org/logviewer?job_id=419126823&repo=autolandTEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-old-breakpoint.js- windows only https://treeherder.mozilla.org/logviewer?job_id=419132897&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/77cc88a1e2b41c8157feb0979caaabaf8079d34d
Flags: needinfo?(hmanilla)
|
||
Comment 6•1 year ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bomsy, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(poirot.alex)
Flags: needinfo?(hmanilla)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(poirot.alex)
You need to log in
before you can comment on or make changes to this bug.
Description
•