-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies still missing with com.google.android.gms.oss-licenses-plugin:0.10.1 #119
Comments
Can you attach your build.gradle files or a repro test project. |
I just tried to reproduce the problem and the thing that broke the gradle plugin was when I added a library module to the project and added it to the app gradle file. Returning to 0.9.5 and that part is working. |
My Application.zip |
+1 |
|
Yes, multiple library modules, and my app module depends on them (implementation). None of my library modules' dependencies are listed in oss-license activity. |
@jkasnicki The reason for the problem: How to temporary work around the bug
to
|
@hnljp I have the same problem. I have fixed it as your guide. and it worked fine. |
I don't use product flavors and declaring dependencies as
My setup:
|
This was released in version 0.10.2. |
I can confirm that 0.10.2 solved my problem |
also verified here. |
Describe the bug
Like with com.google.android.gms:oss-licenses-plugin:0.10.0, com.google.android.gms:oss-licenses-plugin:0.10.1 is still thinking that the app does not have any open source licenses.
Using com.android.tools.build:gradle:3.5.3 (same problem with 3.5.1), gradle 6.0.1 (same problem with 5.6.0).
To Reproduce
Apply any dependency. And try to build.
Expected behavior
Three files should get generated by the oss-licenses-plugin, containing all the information needed:
app/build/generated/third_party_licenses/res/dependencies.json
app/build/generated/third_party_licenses/res/raw/third_party_license_metadata
app/build/generated/third_party_licenses/res/raw/third_party_licenses
But the problem is that the two files are generated blank:
app/build/generated/third_party_licenses/res/raw/third_party_license_metadata
app/build/generated/third_party_licenses/res/raw/third_party_licenses
And the third file gets generated as an empty array:
`[
]`
app/build/generated/third_party_licenses/res/dependencies.json
Screenshots
Desktop (please complete the following information):
Additional context
A full list of licenses was generated with com.google.android.gms.oss-licenses-plugin:0.9.5
In case it makes a difference, this is on macOS 10.14.6 but I have also tested on Ubuntu 16.4 with the same result.
And also an extra information, I have tried to delete the third_party_libraries directory, to make sure that it is getting recreated and it is. It is still producing the empty files as described above.
The text was updated successfully, but these errors were encountered: