Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root: true to eslintrc #2925

Closed
wants to merge 1 commit into from
Closed

Add root: true to eslintrc #2925

wants to merge 1 commit into from

Conversation

hubgit
Copy link
Contributor

@hubgit hubgit commented Dec 12, 2020

Set root: true in the .eslintrc template, so that ESLint doesn't try to combine the configuration in the functions directory with the configuration in an .eslintrc file in the parent app directory.

Set `root: true` in the .eslintrc template, so that ESLint doesn't try to combine the configuration in the `functions` directory with the configuration in an `.eslintrc` file in the parent app directory.
@google-cla
Copy link

google-cla bot commented Dec 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 12, 2020
@hubgit
Copy link
Contributor Author

hubgit commented Dec 12, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Manual indication that this has passed CLA. and removed cla: no labels Dec 12, 2020
@samtstern
Copy link
Contributor

@hubgit thanks for the contribution! Assigning to @bkendall who is our lint master.

@bkendall
Copy link
Contributor

bkendall commented Jan 6, 2021

Sorry for being super delayed. I like this idea, but could you update this branch with master and then update both _eslintrc files (which were just updated to be a bit more simple) to include this change? Thanks!

@bkendall
Copy link
Contributor

Taking the idea and running with it (keeping your initial commit) in #3029. Thanks!

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants