Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated token API #2741

Merged
merged 4 commits into from
Apr 8, 2019
Merged

remove deprecated token API #2741

merged 4 commits into from
Apr 8, 2019

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Apr 5, 2019 •
edited

Remove deprecated token API as requested in #2761. Use instanceIDWithHandler: instead.

@charlotteliang charlotteliang added this to the Firebase 6 milestone Apr 5, 2019
paulb777
paulb777 approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll fix the pod lib lint issue in the PR I'm working on to update versions.

@charlotteliang
Copy link
Contributor Author

Everything is green except for pod lib lint now.

@charlotteliang charlotteliang merged commit 0212c46 into master Apr 8, 2019
@charlotteliang charlotteliang deleted the fcm-deprecate-token-call branch April 8, 2019 23:19
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@charlotteliang @Corrob
remove deprecated token API (#2741)
086b3ba
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@maksymmalyhin maksymmalyhin Awaiting requested review from maksymmalyhin

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlotteliang @paulb777 @googlebot