Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message #2614

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Improve error message #2614

merged 1 commit into from
Mar 22, 2019

Conversation

paulb777
Copy link
Member

Improve invalid app name error message based on feedback in #2609

@paulb777 paulb777 mentioned this pull request Mar 22, 2019
Closed
ryanwilson
ryanwilson approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@paulb777 paulb777 merged commit b76c843 into master Mar 22, 2019
@paulb777 paulb777 deleted the pb-chars branch March 22, 2019 23:33
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@paulb777 @Corrob
Improve error message (#2614)
838ec31
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulb777 @ryanwilson @googlebot