Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in -[FSRWebSocket _sendFrameWithOpcode:data:] line 1389 #2485

Closed
mikhailmulyar opened this issue Mar 7, 2019 · 5 comments · Fixed by #2488
Closed

Crash in -[FSRWebSocket _sendFrameWithOpcode:data:] line 1389 #2485

mikhailmulyar opened this issue Mar 7, 2019 · 5 comments · Fixed by #2488
Assignees
@paulb777
Labels
api: database
Milestone
5.19.0

Comments

@mikhailmulyar
Copy link

  • Xcode version: 10.1
  • Firebase SDK version: 5.15.0
  • Firebase Component: Database
  • Component version: 5.0.4

Describe the problem:
Crash happening because of Assert in FSRWebSocket. It is repeating in release environment with several of our customers. It happens at application start up and if it happens its not avoidable, application with crash all the time.

Assertion failed: (NO), function -[FSRWebSocket _sendFrameWithOpcode:data:], file /Users/vagrant/git/Pods/FirebaseDatabase/Firebase/Database/third_party/SocketRocket/FSRWebSocket.m, line 1389.

0  libsystem_kernel.dylib         0x1f287f104 __pthread_kill + 8
1  libsystem_pthread.dylib        0x1f28fb020 pthread_kill$VARIANT$mp + 380
2  libsystem_c.dylib              0x1f27d6d78 abort + 140
3  libsystem_c.dylib              0x1f27a467c basename_r + 314
4  ConceptOffice                  0x103242fd0 -[FSRWebSocket stream:handleEvent:] (FSRWebSocket.m:1428)
5  ConceptOffice                  0x1032407cc __21-[FSRWebSocket send:]_block_invoke (FSRWebSocket.m:746)
6  libdispatch.dylib              0x1f27216c8 _dispatch_call_block_and_release + 24
7  libdispatch.dylib              0x1f2722484 _dispatch_client_callout + 16
8  libdispatch.dylib              0x1f26c9bd0 _dispatch_lane_serial_drain$VARIANT$mp + 592
9  libdispatch.dylib              0x1f26ca718 _dispatch_lane_invoke$VARIANT$mp + 432
10 libdispatch.dylib              0x1f26d2eb8 _dispatch_workloop_worker_thread + 600
11 libsystem_pthread.dylib        0x1f29050dc _pthread_wqthread + 312
12 libsystem_pthread.dylib        0x1f2907cec start_wqthread + 4

Steps to reproduce:
We are not able to reproduce issue on test devices.
@Den-Ree
Copy link

Den-Ree commented Mar 7, 2019

We have the same problem and now it's crashing on production. If return back to Firebase (4.13.0) FirebaseDatabase (4.1.5) everything works again.

@paulb777 paulb777 mentioned this issue Mar 7, 2019
Merged
@paulb777 paulb777 self-assigned this Mar 7, 2019
@paulb777 paulb777 added this to the M45 milestone Mar 7, 2019
@Den-Ree
Copy link

Den-Ree commented Mar 8, 2019

@paulb777 thanks for the quick reaction, do you know when M45 should be released?

@ryanwilson
Copy link
Member

ryanwilson commented Mar 8, 2019 •
edited

@Den-Ree By policy, we don't commit to dates for upcoming releases, but I can say that we are hoping to get M45 out with this issue fixed the week of March 18th. If you wanted to get a release out sooner, you can always point your CocoaPod to the master branch for Database although we do suggest moving it back to the publicly released version after M45 is released. Edit: use @paulb777's advice in #2485 (comment)

@paulb777
Copy link
Member

paulb777 commented Mar 8, 2019

@Den-Ree In the meantime, another workaround is directly applying the fix in #2488 to the post-downloaded Pods in your project.

@Den-Ree
Copy link

Den-Ree commented Mar 10, 2019 •
edited

@paulb777 and @ryanwilson thank you both for the help. We did the fix and sent to the users with the problem, everything works🎊.

@paulb777 paulb777 mentioned this issue Mar 11, 2019
Closed
@firebase firebase locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulb777 paulb777

Labels
api: database
Projects
None yet
Milestone
5.19.0
Development

Successfully merging a pull request may close this issue.

Add missing nil check firebase/firebase-ios-sdk
5 participants
@paulb777 @ryanwilson @mikhailmulyar @Den-Ree @google-oss-bot