Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set a timeout on Functions. #2329

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Add ability to set a timeout on Functions. #2329

merged 4 commits into from
Feb 25, 2019

Conversation

bklimt
Copy link
Contributor

@bklimt bklimt commented Jan 31, 2019

Add a timeoutInterval property to FIRHTTPSCallable.h.

@bklimt bklimt requested a review from paulb777 January 31, 2019 04:53
paulb777
paulb777 reviewed Jan 31, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passing to @ryanwilson for API review

paulb777
paulb777 requested changes Jan 31, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix style and any other travis issues

@ryanwilson
Copy link
Member

@bklimt did you want to land this for M43?

@bklimt
Copy link
Contributor Author

bklimt commented Feb 12, 2019

@ryanwilson Thank you for checking, but no, I'd like to hold this for M44 so I can get the iOS, Android, and Web versions in at the same release.

@bklimt
Copy link
Contributor Author

bklimt commented Feb 19, 2019

That Travis failure looks like it doesn't have anything to do with my changes.

@ryanwilson
Copy link
Member

Paul fixed the Travis issue and I restarted the failed jobs - you're good to go now @bklimt.

@ryanwilson ryanwilson added this to the M44 milestone Feb 21, 2019
@bklimt bklimt merged commit 075e586 into master Feb 25, 2019
@paulb777 paulb777 deleted the klimt.functions-timeout branch October 2, 2019 19:19
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
5.18.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bklimt @ryanwilson @paulb777 @googlebot