Add a boolean value on whether to use direct channel callback for all ios versions #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack for all iOS versions
|
Please fix travis issue: |
paulb777
requested changes
Sep 25, 2018
|
|
||
| #import <OCMock/OCMock.h> | ||
|
|
||
| #ifdef COCOAPODS |
There was a problem hiding this comment.
Remove ifdef. It should be created by copybara
paulb777
reviewed
Sep 25, 2018
|
One more change needed. I noticed 'GoogleUtilities/Environment' is missing from the podspec dependencies in https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMessaging.podspec. It's working because of transitive dependencies, but it should be added to make the dependency explicit. |
morganchen12
approved these changes
Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new boolean value that control whether to use direct channel callback for all iOS versions. This partially resolves the issue #1409.
We are separating the callback between apns and direct channel. Right now for iOS 10 and above, direct channel message delivered at FIRMessagingDelegate, while for iOS 9 and below, they were delivered at UIApplicationDelegate. To not break existing behavior, if user likes to receive direct channel callback using FIRMessagingDelegate instead of UIApplicationDelegate for all ios versions, they can now set the boolean value useMessagingDelegateForDirectChannel to true.