Make missing analytics a warning instead of error #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
approved these changes
Aug 8, 2018
baolocdo
reviewed
Aug 8, 2018
|
@baolocdo Does this work? |
baolocdo
reviewed
Aug 9, 2018
Firebase/Core/FIRApp.m
Outdated
| @"it, include Firebase/Core in the Podfile or add " | ||
| @"FirebaseAnalytics.framework to the Link Build Phase"); | ||
| FIRLogWarning(kFIRLoggerCore, @"I-COR000022", | ||
| @"Firebase Analytics is not available. To add " |
There was a problem hiding this comment.
nit: please fill all the width of the columns (should be 100 char/column).
baolocdo
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce confusion on questions like https://stackoverflow.com/questions/51627290/5-4-1-firebase-corei-cor000022-firebase-analytics-is-not-available/51737237