Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCM: Not handling method un-swizzling properly for UNUserNotificationCenterDelegate #1481

Closed
uzma-sayyed opened this issue Jun 29, 2018 · 1 comment · Fixed by #1483
Closed

FCM: Not handling method un-swizzling properly for UNUserNotificationCenterDelegate #1481

uzma-sayyed opened this issue Jun 29, 2018 · 1 comment · Fixed by #1483
Assignees
@morganchen12
Labels
api: messaging
Milestone
5.5.0

Comments

@uzma-sayyed
Copy link

FCM is swizzling both the methods of UNUserNotificationCenterDelegate i.e. willPresentNotification and didReceiveNotificationResponse.
FIRMessagingRemoteNotificationsProxy.m

But while un-swizzling, only willPresentNotification method is un-swizzled and not didReceiveNotificationResponse.
FIRMessagingRemoteNotificationsProxy.m

Due to this, the method didReceiveNotificationResponse of notificationDelegate class always points to FCM even after notificationDelegate is changed to a different instance. This creates a lot of issues when there are multiple SDKs swizzling these methods.
@saumitrabhave
Copy link

saumitrabhave commented Jun 29, 2018 •
edited

I think this is the commit of interest 5496eff , PR #324 This commit added the support for didReceiveNotificationResponseSelector but missed it in the unswizzle part.

@morganchen12 morganchen12 self-assigned this Jun 29, 2018
@morganchen12 morganchen12 mentioned this issue Jun 29, 2018
Merged
@paulb777 paulb777 added this to the M30 milestone Jun 29, 2018
@firebase firebase locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morganchen12 morganchen12

Labels
api: messaging
Projects
None yet
Milestone
5.5.0
Development

Successfully merging a pull request may close this issue.

Fix missing method in Messaging unswizzle morganchen12/firebase-ios-sdk
4 participants
@paulb777 @saumitrabhave @morganchen12 @uzma-sayyed