Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add informative error to JWT parse failures #1436

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Add informative error to JWT parse failures #1436

merged 1 commit into from
Jun 28, 2018

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Jun 21, 2018 •
edited

  • Fixes a potential crash when decoding malformed JWTs with less than three components.
  • Improves error messaging when decoding JWTs.
  • Removes deprecated usage of [NSError new] in tests.

Do not merge before #1448.

API review: b/110799959

@morganchen12 morganchen12 added this to the M29 milestone Jun 21, 2018
@morganchen12 morganchen12 self-assigned this Jun 21, 2018
@morganchen12 morganchen12 changed the title Fix bad parsing of JWT dates Add informative error to JWT parse failures Jun 25, 2018
@morganchen12
Copy link
Contributor Author

Test failures seem to be coming out of Messaging.

ryanwilson
ryanwilson approved these changes Jun 26, 2018
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM.

@morganchen12
Copy link
Contributor Author

Pending API review before merge.

@morganchen12
Copy link
Contributor Author

morganchen12 commented Jun 28, 2018 •
edited

Passed API review. (b/110799959)

@morganchen12 morganchen12 merged commit 7aa852f into firebase:master Jun 28, 2018
@morganchen12 morganchen12 deleted the auth2 branch June 28, 2018 19:02
@firebase firebase locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@protocol86 protocol86 Awaiting requested review from protocol86

Assignees

@morganchen12 morganchen12

Labels
api: auth cla: yes
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@morganchen12 @ryanwilson @paulb777 @googlebot