Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify activate path to only update experiments for firebase namespace #9972

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Modify activate path to only update experiments for firebase namespace #9972

merged 3 commits into from
Jul 1, 2022

Conversation

karenyz
Copy link
Contributor

@karenyz karenyz commented Jun 30, 2022

Similar fix to #7604, which only updated the fetch path but not activate

Tracked internally in b/211879339

@google-oss-bot
Copy link

google-oss-bot commented Jun 30, 2022 •
edited

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 79.46% (e2542c7) to 79.58% (ec24d6e) by +0.12%.

    FilenameBase (e2542c7)Merge (ec24d6e)Diff
    FIRRemoteConfig.m83.02%83.61%+0.58%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BigbxEwMKr.html

@karenyz karenyz requested a review from paulb777 June 30, 2022 21:00
paulb777
paulb777 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karenyz karenyz merged commit d5637c4 into master Jul 1, 2022
@karenyz karenyz deleted the kz-rc-abt-fix branch July 1, 2022 15:21
@firebase firebase locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karenyz @google-oss-bot @paulb777