Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore TransactionOptions added, to specify maxAttempts #9838

Merged
merged 23 commits into from
May 30, 2022
Merged

Firestore TransactionOptions added, to specify maxAttempts #9838

merged 23 commits into from
May 30, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented May 24, 2022 •
edited

This is a port of firebase/firebase-android-sdk#3664, which adds the new TransactionOptions class to Firestore, which can be used to specify the maximum number of attempts to run a transaction before giving up. Previously, this maximum was hardcoded to 5.

@dconeybe dconeybe self-assigned this May 24, 2022
@google-oss-bot
Copy link

google-oss-bot commented May 24, 2022 •
edited

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (a71dbaf)Merge (3afbfc8)Diff
    CocoaPods6.89 MB6.89 MB+112 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Gnh6N8odE6.html

@google-oss-bot
Copy link

google-oss-bot commented May 24, 2022 •
edited

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.38% (a71dbaf) to 88.42% (3afbfc8) by +0.04%.

    FilenameBase (a71dbaf)Merge (3afbfc8)Diff
    firestore.cc95.00%95.03%+0.03%
    FIRFirestore.mm91.22%91.43%+0.21%
    FIRTransactionOptions.mm?100.00%?
    leveldb_key.cc98.14%98.63%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/46IJUCl9jk.html

@dconeybe dconeybe marked this pull request as ready for review May 25, 2022 14:32
@dconeybe dconeybe assigned tom-andersen and wu-hui and unassigned dconeybe May 25, 2022
@dconeybe
Copy link
Contributor Author

@tom-andersen Can you take a quick look at this PR to make sure it aligns with your designs for transaction options?
@wu-hui Could you do a full review?
Thank you both.

dconeybe added a commit to firebase/firebase-cpp-sdk that referenced this pull request May 25, 2022
@dconeybe
firestore.cmake: pin to the HEAD commit of firebase/firebase-ios-sdk#…
ae41684 
…9838, which adds TransactionOptions
@dconeybe dconeybe mentioned this pull request May 25, 2022
Merged
wu-hui
wu-hui approved these changes May 30, 2022
View reviewed changes
Firestore/Source/API/FIRTransactionOptions.mm Outdated Show resolved Hide resolved
@wu-hui wu-hui assigned dconeybe and unassigned tom-andersen and wu-hui May 30, 2022
@dconeybe dconeybe merged commit 585b4c8 into master May 30, 2022
@dconeybe dconeybe deleted the dconeybe/TransactionOptions branch May 30, 2022 16:41
dconeybe added a commit to firebase/firebase-cpp-sdk that referenced this pull request May 31, 2022
@dconeybe
firestore.cmake: pin to the head commit of the master branch, now that …
de7a6cd 
…firebase/firebase-ios-sdk#9838 has been merged
@dconeybe dconeybe mentioned this pull request May 31, 2022
Merged
@dconeybe dconeybe mentioned this pull request Jun 27, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@tom-andersen tom-andersen Awaiting requested review from tom-andersen

Assignees

@dconeybe dconeybe

Labels
api: firestore public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dconeybe @google-oss-bot @wu-hui @tom-andersen