Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user agent and heartbeat headers. #9066

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Add user agent and heartbeat headers. #9066

merged 5 commits into from
Mar 15, 2022

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Dec 8, 2021 •
edited

Add platform logging headers for Firebase Auth.

@google-oss-bot
Copy link

google-oss-bot commented Dec 8, 2021 •
edited

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (0ab2f04)Merge (8d4dce9)Diff
    CocoaPods?1.03 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aeb4urFbiB.html

@google-oss-bot
Copy link

google-oss-bot commented Dec 8, 2021 •
edited

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.49% (f6271d8) to 68.47% (a75d273) by -0.02%.

    FilenameBase (f6271d8)Merge (a75d273)Diff
    FIRAuthBackend.m84.21%83.87%-0.34%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uAaIm7dURr.html

@rosalyntan rosalyntan marked this pull request as ready for review January 28, 2022 22:42
@ncooke3 ncooke3 self-assigned this Feb 1, 2022
@ncooke3 ncooke3 added this to the 8.14.0 - M113 milestone Mar 1, 2022
ncooke3
ncooke3 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Please move the CHANGELOG update to the v8.14.0 entry!

ncooke3
ncooke3 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rosalyntan rosalyntan merged commit 0fb31ac into master Mar 15, 2022
@rosalyntan rosalyntan deleted the rosalyntan.heartbeat branch March 15, 2022 18:41
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

@ncooke3 ncooke3

Labels
api: auth
Projects
None yet
Milestone
8.14.0 - M113
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosalyntan @google-oss-bot @ncooke3