Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on FPRDecodeString when using Thread Sanitizer #8628

Closed
bluelagon opened this issue Sep 7, 2021 · 4 comments · Fixed by #8631
Closed

crash on FPRDecodeString when using Thread Sanitizer #8628

bluelagon opened this issue Sep 7, 2021 · 4 comments · Fixed by #8631
Labels
api: performance needs-info

Comments

@bluelagon
Copy link

bluelagon commented Sep 7, 2021 •
edited

Step 0: Are you in the right place?

  • For issues or feature requests related to the code in this repository
    file a Github issue.
    • If this is a feature request please use the Feature Request template.
  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general (non-iOS) Firebase discussion, use the firebase-talk
    google group.
  • For backend issues, console issues, and other non-SDK help that does not fall under one
    of the above categories, reach out to
    Firebase Support.
  • Once you've read this section and determined that your issue is appropriate for
    this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.5.1
  • Firebase SDK version: 8.6.0
  • Installation method: CocoaPods (select one)
  • Firebase Component: Analytics, Crashlytics, Performance

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

For reproducing, I just check the Address Sanitizer in Edit Scheme > Run > Diagnostics and I run my project, it crashes systematically.

Capture d’écran 2021-09-07 à 14 05 10

Capture d’écran 2021-09-07 à 14 05 24
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@bluelagon
Copy link
Author

For information I get the crash only on the simulator and not from a device. On the simulator I tested on a: iPhone 12 mini / iOS 14.5

@rizafran
Copy link
Contributor

rizafran commented Sep 7, 2021

Hi @bluelagon, I've tried to enable the Address Sanitizer via Edit Schemes and run my sample app to iPhone 12 mini simulator, but I wasn't able to get the same crash. Have you tried to update your SDK using the pod update command and see if the issue persists? Also, you may share the full error logs you've encountered. Thanks.

@bluelagon
Copy link
Author

Thank you @rizafran. I did a pod update and updated the Performance SDK to 8.6.1 and it fixed the problem. Thank you for your help.

@jeremyjiang-dev jeremyjiang-dev mentioned this issue Sep 8, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: performance needs-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix heap-buffer overflow from FPRDecodeString firebase/firebase-ios-sdk
3 participants
@google-oss-bot @bluelagon @rizafran