Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions: don't send dummy FAC token #8558

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Functions: don't send dummy FAC token #8558

merged 8 commits into from
Aug 23, 2021

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Aug 20, 2021 •
edited

Fixes firebase/flutterfire#6794 for Apple platforms.

b/197236400

@google-cla google-cla bot added the cla: yes label Aug 20, 2021
@google-oss-bot
Copy link

google-oss-bot commented Aug 20, 2021 •
edited

Coverage Report

Affected SDKs

  • FirebaseFunctions-iOS-FirebaseFunctions.framework

    SDK overall coverage changed from 60.54% (03cf705) to 60.81% (5d68b3b) by +0.27%.

    Filename Base (03cf705) Head (5d68b3b) Diff

Test Logs

paulb777
paulb777 reviewed Aug 20, 2021
View reviewed changes
Functions/CHANGELOG.md Outdated Show resolved Hide resolved
Functions/Example/Tests/FIRFunctionsTests.m Outdated Show resolved Hide resolved
Functions/FirebaseFunctions/FUNContext.m Show resolved Hide resolved
paulb777
paulb777 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix style and LGTM on green CI

@maksymmalyhin maksymmalyhin added this to the 8.7.0 - M103 milestone Aug 20, 2021
@nilsreichardt nilsreichardt mentioned this pull request Aug 23, 2021
Closed
@maksymmalyhin maksymmalyhin merged commit daa83b9 into master Aug 23, 2021
@maksymmalyhin maksymmalyhin deleted the mm/func-appcheck branch August 23, 2021 14:53
@firebase firebase locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: functions cla: yes
Projects
None yet
Milestone
8.7.0 - M103
3 participants
@maksymmalyhin @google-oss-bot @paulb777