Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Performance logs too much when data collection disabled (2) #8423

Closed
ghost opened this issue Jul 22, 2021 · 1 comment · Fixed by #8620
Closed

Firebase Performance logs too much when data collection disabled (2) #8423

ghost opened this issue Jul 22, 2021 · 1 comment · Fixed by #8620
Assignees

Comments

@ghost
Copy link

ghost commented Jul 22, 2021

Step 1: Describe your environment

  • Xcode version: 12.5
  • Firebase SDK version: 8.4.0
  • Installation method: CocoaPods
  • Firebase Component: Performance

Step 2: Describe the problem

Reopening problem #4238:

Firebase Performance spams in log when disabled. Disabled module via isInstrumentationEnabled=false and isDataCollectionEnabled=false produces spam in log

[Firebase/Performance][I-PRF100013] Dropping event since data collection is disabled.

Suggested workaround in #4238 (set -FIRDebugEnabled) in not a fix, its silently enables Performance module.

My suggestion is change

FPRLogError(kFPRClientPerfNotConfigured, @"Dropping event since data collection is disabled.");

to

FPRLogDebug(kFPRClientPerfNotConfigured, @"Dropping event since data collection is disabled.");

Or something like that, because disabled traces is not an error at all.

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants