Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the handling of Unicode characters in log and assertion messages #8372

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Fix the handling of Unicode characters in log and assertion messages #8372

merged 2 commits into from
Jul 10, 2021

Conversation

var-const
Copy link
Contributor

Currently, any UTF-8 characters outside the ascii set may be encoded incorrectly.

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@var-const var-const requested a review from dconeybe July 9, 2021 23:48
@google-oss-bot
Copy link

google-oss-bot commented Jul 10, 2021 •
edited

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.49% (d50dd0a) to 88.53% (e06d665) by +0.04%.

    Filename Base (d50dd0a) Head (e06d665) Diff
    leveldb_key.cc 96.79% 97.96% +1.17%
    ordered_code.cc 92.68% 93.24% +0.56%
    task.cc 95.21% 96.41% +1.20%
    write_stream.cc 95.65% 93.48% -2.17%

Test Logs

@dconeybe dconeybe assigned var-const and unassigned dconeybe Jul 10, 2021
@var-const var-const merged commit bd64ba6 into master Jul 10, 2021
@var-const var-const deleted the varconst/fix-unicode-logging2 branch July 10, 2021 01:25
@firebase firebase locked and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@dconeybe dconeybe dconeybe approved these changes

Assignees

@var-const var-const

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@var-const @google-oss-bot @dconeybe