-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest GTMSessionFetcher's new deprecation breaks Storage CI #8294
Comments
@morganchen12 - Can you take care of this? |
Merged
@mwyman fyi also I believe the api docs have always said it should only be used in tests (or tools without UI). |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See https://github.com/firebase/firebase-ios-sdk/pull/8292/checks?check_run_id=2898960029 and
From GTMsessionFetcherService.h:
// DEPRECATED: Callers should use XCTestExpectation instead.
//
// Spin the run loop and discard events (or, if not on the main thread, just sleep the thread)
// until all running and delayed fetchers have completed.
//
// This is only for use in testing or in tools without a user interface.
//
// Synchronous fetches should never be done by shipping apps; they are
// sufficient reason for rejection from the app store.
Given that comment, it seems we might need a more significant refactor than most warnings require.
cc: @thomasvl
The text was updated successfully, but these errors were encountered: