Fixed analyze issues introduced in Xcode 12.5 #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paulb777
commented
Jun 7, 2021
Coverage ReportAffected SDKsNo changes between base commit (ac7bcdc) and head commit (d46cc15). Test Logs
|
maksymmalyhin
approved these changes
Jun 8, 2021
| @@ -245,7 +245,7 @@ + (instancetype)providerWithAuth:(FIRAuth *)auth { | |||
| @param error The error that occurred if any. | |||
| @return The reCAPTCHA token if successful. | |||
| */ | |||
| - (NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **)error { | |||
| - (nullable NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **_Nonnull)error { | |||
There was a problem hiding this comment.
Same here, it will be safer to check for NULL because there might be cases when compiler and analyzer may not catch nullability issue.
There was a problem hiding this comment.
The error pointer for the one call is allocated at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m#L667
There was a problem hiding this comment.
LGTM, thank you for checking. I sill think it is safer to assume nullable pointer to make it less probable to accidentally introduce a crash in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.