Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-App Messaging via SPM missing resource bundle #7715

Closed
khuffie opened this issue Mar 14, 2021 · 6 comments · Fixed by #7788
Closed

In-App Messaging via SPM missing resource bundle #7715

khuffie opened this issue Mar 14, 2021 · 6 comments · Fixed by #7788
Assignees
@christibbs
Labels
api: inappmessaging Firebase In App Messaging Swift Package Manager
Milestone
7.11.0 - M94

Comments

@khuffie
Copy link

khuffie commented Mar 14, 2021

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.4
  • Firebase SDK version: 7.8.1
  • Installation method: Swift Package Manager
  • Firebase Component: Analytics, Crashlytics, InAppMessaging, Messaging

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

I have Firebase integrated via SPM. I am trying to send a test message for In-App Messaging. The device receives the message but I get an error when it attempts to display:

7.8.1 - [Firebase/InAppMessaging][I-IAM400009] Display ran into error for message 592562000580575232: Error Domain=com.firebase.inappmessaging.display Code=1 "Resource bundle is missing." UserInfo={NSLocalizedDescription=Resource bundle is missing.}

Relevant Code:

N/A
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@rizafran rizafran added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Mar 15, 2021
@paulb777
Copy link
Member

It looks like the path to the Resources is wrong at https://github.com/firebase/firebase-ios-sdk/blob/master/Package.swift#L595. It should be ../Resources.

@christibbs Would you validate and if possible, add a regression test to CI?

@raspu
Copy link

raspu commented Mar 22, 2021

We are facing the same issue here, any workaround? I will try to integrate manually...

@christibbs christibbs mentioned this issue Mar 22, 2021
Closed
@christibbs
Copy link
Contributor

christibbs commented Mar 22, 2021 •
edited

@raspu @khuffie I'm working on this currently. When it's resolved we'll likely make a quick patch release for all of our Swift Package Manager users. No workarounds for the moment.

@raspu
Copy link

raspu commented Mar 23, 2021

Thanks @christibbs. I was able to integrate manually, so we are going that way for now. But we would love to move to SPM when available :).

@ncooke3 ncooke3 mentioned this issue Mar 25, 2021
Merged
@ncooke3 ncooke3 added this to the 7.11.0 - M94 milestone Apr 7, 2021
@ncooke3
Copy link
Member

ncooke3 commented Apr 7, 2021

Hi @khuffie & @raspu,

We've implemented a fix for the issue and it will officially release in Firebase 7.11
Thank you for your patience and don't hesitate to reach out if you run into any further issues! 🙂

@firebase firebase locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christibbs christibbs

Labels
api: inappmessaging Firebase In App Messaging Swift Package Manager
Projects
None yet
Milestone
7.11.0 - M94
7 participants
@paulb777 @raspu @khuffie @google-oss-bot @ncooke3 @christibbs @rizafran