Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update experiments for firebase namespace #7604

Merged
merged 6 commits into from
Feb 26, 2021
Merged

Only update experiments for firebase namespace #7604

merged 6 commits into from
Feb 26, 2021

Conversation

karenyz
Copy link
Contributor

@karenyz karenyz commented Feb 24, 2021 •
edited

Currently updateExperimentsWithResponse is being called on fetches for all namespaces, causing issues with experiment exposures as fireperf fetch requests are incorrectly updating experiment data

Tracked internally in b/179461119

@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@google-oss-bot
Copy link

google-oss-bot commented Feb 24, 2021 •
edited

Coverage Report

Affected SDKs

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    SDK overall coverage changed from 80.94% (30aa8ec) to 81.14% (96800e5) by +0.19%.

    Filename Base (30aa8ec) Head (96800e5) Diff
    RCNConfigFetch.m 80.85% 81.70% +0.85%

Test Logs

@karenyz
Copy link
Contributor Author

karenyz commented Feb 25, 2021

not sure why spm tests are failing..

@charlotteliang
Copy link
Contributor

Try build the unit test using swift package manager by opening the package.swift.

charlotteliang
charlotteliang approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@karenyz karenyz merged commit a67da04 into master Feb 26, 2021
@karenyz karenyz deleted the kz-rc-update-experiments branch February 26, 2021 00:52
ziadtamim pushed a commit to ziadtamim/firebase-ios-sdk that referenced this pull request Mar 11, 2021
@karenyz @ziadtamim
Only update experiments for firebase namespace (firebase#7604)
4b407a9 
* Only update experiments for firebase namespace

* Update tests

* Add changelog
@firebase firebase locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@christibbs christibbs Awaiting requested review from christibbs

Assignees
No one assigned
Labels
api: remoteconfig cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karenyz @google-oss-bot @charlotteliang