Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better VoiceOver experience for in-app messages #7445

Merged
merged 8 commits into from
Feb 4, 2021
Merged

Better VoiceOver experience for in-app messages #7445

merged 8 commits into from
Feb 4, 2021

Conversation

christibbs
Copy link
Contributor

  • Announces the in-app message title over VoiceOver at display time
  • Improves accessibility labels
  • Announces close button as the last accessible VoiceOver element (so it's easier to find)

@google-cla google-cla bot added the cla: yes label Feb 3, 2021
@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Feb 3, 2021
@paulb777 paulb777 added this to the 7.7.0 - M90 milestone Feb 3, 2021
paulb777
paulb777 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is it feasible to add unit tests?

paulb777
paulb777 requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are test failures on travis with Xcode 11. PTAL

@christibbs
Copy link
Contributor Author

Nice! Is it feasible to add unit tests?

No, fortunately you get some accessibility test coverage for free since the UI testing framework uses accessibility identifiers. But there's no way to test the posting of a VoiceOver notification at a particular time.

@christibbs christibbs merged commit f6d3a8c into master Feb 4, 2021
@christibbs christibbs deleted the fiam-accessibility branch February 4, 2021 22:03
@firebase firebase locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@charlotteliang charlotteliang Awaiting requested review from charlotteliang

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Milestone
7.7.0 - M90
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christibbs @paulb777 @google-oss-bot