Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+[FIRApp registerInternalLibrary:withName:] take too much time #6902

Closed
shanksGuo opened this issue Nov 5, 2020 · 8 comments · Fixed by #6919
Closed

+[FIRApp registerInternalLibrary:withName:] take too much time #6902

shanksGuo opened this issue Nov 5, 2020 · 8 comments · Fixed by #6919

Comments

@shanksGuo
Copy link

shanksGuo commented Nov 5, 2020

Feature proposal

  • FIRApp: remove +load or reduce the time cost of [FIRApp registerInternalLibrary:withName:]

As image shown below, [FIRApp registerInternalLibrary:withName:] in App launch Initializing phase take 78ms, it is too much for our App launch! So, could you optimize this.

Wish you accept this suggestion!
Screen Shot 2020-11-05 at 13 43 25

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@shanksGuo
Copy link
Author

Sadlly, according to my multi tests, the block time can be up to 100ms -_-

@shanksGuo
Copy link
Author

The time cost is very important to our App, hope you can handle this ASAP. Thanks in advance!

@maksymmalyhin
Copy link
Contributor

maksymmalyhin commented Nov 6, 2020

@shanksGuo Thank you for the detailed report pointing out to the exact place that causes issue for your application! We implemented some optimizations to avoid the slow part running from +load and running it on a background queue.

Unfortunately it's a bit too late to include the change to the next release, so it'll be include to the release after. In the meanwhile we will appreciate your feedback if you could test the #6919 changes from the branch.

@shanksGuo
Copy link
Author

@maksymmalyhin Thank you. By the way, I have a question, I'm on release-7.0 now, if I want to fetch the code optimized, which branch can I use?

@maksymmalyhin
Copy link
Contributor

@shanksGuo The changes have been merged to master.

@shanksGuo
Copy link
Author

@maksymmalyhin Thank you, after checkout lastest code, it has been optimized.

@maksymmalyhin
Copy link
Contributor

@shanksGuo Thank you for testing on you end!

@firebase firebase locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants