-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Add RemoteConfig Decoder and Encoder #6883
Comments
This quickstart sequence should transform to a single line with Codable - https://github.com/firebase/quickstart-ios/blob/6c420f893cea50d319931451d9fe110c534f9fcf/config/ConfigExample/RemoteConfigViewController.swift#L128-L151 |
#9084 now has an initial implementation of the 2nd(RCValue JSON decoding) and 3rd(setDefaults from Encodable) requests. I'm not sure about the first one. It seems that RC does not have any APIs to get the full configuration, but I'm not sure why that is. So I'm not sure that we should add only a Codable version to do that. I suppose a workaround is for an app to do everything via a single JSON entry? @karenyz or anyone else: Any thoughts/guidance on the above questions? |
I talked with the RC team and it turns out that Android already has an API that returns the full config as a dictionary. See https://firebase.google.com/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig#getAll%28%29 So it looks like we should implement a |
After more thought, a |
Feature proposal
Decoder
Would be great to have a Decoder like
Firestore.Decoder
to do something like this:RemoteConfig.Decoder
should be able to decode 'RemoteConfigValue' as well:Encoder
Would be great to have also an Encoder to set defaults:
or better, like for Firestore
ref.setValue(from: Encodable)
The text was updated successfully, but these errors were encountered: