Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated RC APIs #6637

Merged
merged 8 commits into from
Oct 1, 2020
Merged

Remove deprecated RC APIs #6637

merged 8 commits into from
Oct 1, 2020

Conversation

karenyz
Copy link
Contributor

@karenyz karenyz commented Oct 1, 2020 •
edited

Removing following methods:

  • isDeveloperModeEnabled
  • initWithDeveloperModeEnabled:developerModeEnabled
  • activateWithCompletionHandler:completionHandler
  • activateFetched
  • configValueForKey:namespace
  • configValueForKey:namespace:source
  • allKeysFromSource:namespace
  • keysWithPrefix:namespace
  • setDefaults:namespace
  • setDefaultsFromPlistFileName:namespace
  • defaultValueForKey:namespace

Fixes #6546

@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@morganchen12 morganchen12 added this to the Firebase 7 milestone Oct 1, 2020
@karenyz karenyz requested a review from paulb777 October 1, 2020 20:58
paulb777
paulb777 reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you also need to rebase or merge master to resolve a Changelog conflict

FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated Show resolved Hide resolved
FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated Show resolved Hide resolved
@karenyz karenyz merged commit f56afe9 into master Oct 1, 2020
@karenyz karenyz deleted the kz-rc-deprecated-apis branch October 2, 2020 00:31
@firebase firebase locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig cla: yes public-api-change
Projects
None yet
Milestone
Firebase 7 - M82
Development

Successfully merging this pull request may close these issues.

Remote Config: Remove deprecated APIs
4 participants
@karenyz @paulb777 @morganchen12 @google-oss-bot