Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth emulator support to public API. #6624

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add auth emulator support to public API. #6624

merged 2 commits into from
Oct 1, 2020

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Sep 30, 2020 •
edited

Add auth emulator support useEmulatorWithHost:port to public API.

Implementation added in #6402

@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@rosalyntan rosalyntan marked this pull request as ready for review September 30, 2020 23:14
ryanwilson
ryanwilson approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I assume the Facebook test failures are API limits, I don't think it should be a blocker for submitting (or you can re-run them until they work)

paulb777
paulb777 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could find a way to run the Facebook integration tests without hitting the API limit so often.

@rosalyntan rosalyntan merged commit 312f733 into master Oct 1, 2020
@rosalyntan rosalyntan deleted the rosalyntan.emulator branch October 1, 2020 17:46
@firebase firebase locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: auth cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rosalyntan @paulb777 @ryanwilson @google-oss-bot