Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InstanceID deprecation warning #6585

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Add InstanceID deprecation warning #6585

merged 6 commits into from
Sep 29, 2020

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Sep 28, 2020 •
edited

Adding deprecation warnings that are documented in the token API review doc.

paulb777
paulb777 reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI

Firebase/InstanceID/CHANGELOG.md Outdated Show resolved Hide resolved
FirebaseMessaging/CHANGELOG.md Outdated Show resolved Hide resolved
maksymmalyhin
maksymmalyhin approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

@charlotteliang charlotteliang merged commit f0e7b8e into master Sep 29, 2020
@charlotteliang charlotteliang deleted the iid-deprecation branch September 29, 2020 20:35
@firebase firebase locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@kroikie kroikie Awaiting requested review from kroikie

@andirayo andirayo Awaiting requested review from andirayo

@egilmorez egilmorez Awaiting requested review from egilmorez

@gsakakihara gsakakihara Awaiting requested review from gsakakihara

Assignees
No one assigned
Labels
api: instanceid api: messaging cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@charlotteliang @paulb777 @maksymmalyhin @googlebot @google-oss-bot