Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchOS SPM support #6584

Closed
jostster opened this issue Sep 28, 2020 · 4 comments · Fixed by #6705
Closed

watchOS SPM support #6584

jostster opened this issue Sep 28, 2020 · 4 comments · Fixed by #6705
Labels
api: crashlytics Swift Package Manager type: feature request watchOS
Projects
Swift Package Manager Support

Comments

@jostster
Copy link
Contributor

Feature proposal

  • Firebase Component: Crashlytics

Figured I would create a central place to talk about watchOS SPM support. One option is using the platform param for the SPM file which will allow some of the modules that support watchOS to be built for that platform.
@jostster
Copy link
Contributor Author

https://docs.swift.org/package-manager/PackageDescription/PackageDescription.html#target-dependency is in Swift5.3, might be helpful.

@paulb777 paulb777 added this to To do in Swift Package Manager Support via automation Sep 28, 2020
@paulb777
Copy link
Member

paulb777 commented Oct 8, 2020

Based on https://forums.swift.org/t/platform-specific-products/39186, looking for ideas about an approach to define watchOS support for some of the Firebase products without having to ifdef out all the rest for watchOS.

@jostster
Copy link
Contributor Author

jostster commented Oct 8, 2020

Would something like this work? https://forums.swift.org/t/package-manager-conditional-target-dependencies/31306/2?

@paulb777
Copy link
Member

paulb777 commented Oct 8, 2020

Thanks @jostster ! That approach is looking promising. I'll try to get a PR up in the next day or two ...

@paulb777 paulb777 mentioned this issue Oct 9, 2020
Merged
Swift Package Manager Support automation moved this from To do to Done Oct 9, 2020
@firebase firebase locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: crashlytics Swift Package Manager type: feature request watchOS
Projects
No open projects
Swift Package Manager Support
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial SPM building for watchOS firebase/firebase-ios-sdk
5 participants
@paulb777 @jostster @ryanwilson @morganchen12 @google-oss-bot