Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase 6.27.0 crashes on FIRCLSFileWriteString #6048

Closed
ab-rdarts opened this issue Jul 15, 2020 · 7 comments
Closed

Firebase 6.27.0 crashes on FIRCLSFileWriteString #6048

ab-rdarts opened this issue Jul 15, 2020 · 7 comments
Labels
api: crashlytics
Milestone
6.29.0 - M76

Comments

@ab-rdarts
Copy link

ab-rdarts commented Jul 15, 2020 •
edited

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 11.5
  • Firebase SDK version: 6.27.0
  • Firebase Component: Crashlytics
  • Component version: 4.2.0
  • Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

We see crashes on user devices related to Firebase components in our application in production mode. It's strange that these crashes appear only in Xcode organizer. Crashed thread looks like this:

Thread 9 name:
Thread 9 Crashed:
0   libsystem_platform.dylib      	0x00000001ba4c6384 _platform_strlen + 4
1   61.06.100                     	0x00000001014d4850 FIRCLSFileWriteString + 32 (FIRCLSFile.m:334)
2   61.06.100                     	0x00000001014d481c FIRCLSFileWriteHashEntryString + 36 (FIRCLSFile.m:535)
3   61.06.100                     	0x00000001014cd650 FIRCLSContextRecordMetadata + 248 (FIRCLSContext.m:405)
4   61.06.100                     	0x00000001014cd520 __FIRCLSContextInitialize_block_invoke_5 + 104 (FIRCLSContext.m:230)
5   libdispatch.dylib             	0x00000001ba2f3a38 _dispatch_call_block_and_release + 24 (init.c:1372)
6   libdispatch.dylib             	0x00000001ba2f47d4 _dispatch_client_callout + 16 (object.m:511)
7   libdispatch.dylib             	0x00000001ba298d8c _dispatch_queue_override_invoke + 952 (inline_internal.h:2427)
8   libdispatch.dylib             	0x00000001ba2a5030 _dispatch_root_queue_drain + 372 (inline_internal.h:2482)
9   libdispatch.dylib             	0x00000001ba2a58d4 _dispatch_worker_thread2 + 128 (queue.c:6072)
10  libsystem_pthread.dylib       	0x00000001ba4d51b4 _pthread_wqthread + 464 (pthread.c:2361)
11  libsystem_pthread.dylib       	0x00000001ba4d7cd4 start_wqthread + 4

Relevant Code:
@ab-rdarts
Copy link
Author

Example of such crashlog here:
2020-07-14_21-10-18.5762_-0500-41b88af88e30ba3efe0c790850209eeb561b77c5.crash.zip

@mikehardy mikehardy mentioned this issue Jul 17, 2020
Closed
5 tasks
@githubzephyrmobile
Copy link

any comments about this issue?

@morganchen12
Copy link
Contributor

morganchen12 commented Jul 20, 2020 •
edited

Looks like the crash is happening in Crashlytics' context recording code, which is very not good. Are you able to reproduce this crash consistently?

@morganchen12 morganchen12 mentioned this issue Jul 20, 2020
Merged
@ab-rdarts
Copy link
Author

we cannot reproduce it, but we see many such crashes in production code. Also we see related crashes with__FIRCLSContextInitialize_block_invoke.27 + 52 (FIRCLSContext.m:191)

Screen Shot 2020-07-20 at 20 41 24

Screen Shot 2020-07-20 at 20 41 13

2020-07-14_18-34-51.2768_-0700-7875ced1d0d1aa41a579af3b9731bc2eaff8845c.crash.zip

@morganchen12
Copy link
Contributor

I've added a patch that fixes a crash in this area. I suspect it is the same crash you're describing, but without a repro I cannot confirm.

The patch should go out in the next release, after which I'll update this thread and you can update your Crashlytics dependency.

@ab-rdarts
Copy link
Author

ok, we will update our application with updated crashlytics and check if this crash still reproduced in production or not.

@morganchen12 morganchen12 added this to the 6.29.0 - M76 milestone Jul 21, 2020
@paulb777
Copy link
Member

Closing since this should be fixed by #6083 in the upcoming 6.29.0.

@firebase firebase locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: crashlytics
Projects
None yet
Milestone
6.29.0 - M76
Development

No branches or pull requests
5 participants
@paulb777 @morganchen12 @ab-rdarts @google-oss-bot @githubzephyrmobile