Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIRInAppMessagingDisplay: protocol method called from a background thread #5972

Closed
airspeed opened this issue Jul 3, 2020 · 1 comment · Fixed by #5978
Closed

FIRInAppMessagingDisplay: protocol method called from a background thread #5972

airspeed opened this issue Jul 3, 2020 · 1 comment · Fixed by #5978
Assignees
@morganchen12
Labels
api: inappmessaging Firebase In App Messaging Docs

Comments

@airspeed
Copy link

airspeed commented Jul 3, 2020

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 11.6 beta
  • Firebase SDK version: 6.27.0
  • Firebase Component: InAppMessaging
  • Component version: 0.21.0
  • Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

The docs for FIRInAppMessagingDisplay#displayMessage:displayDelegate: at https://firebase.google.com/docs/reference/ios/firebaseinappmessaging/api/reference/Protocols/FIRInAppMessagingDisplay.html#-displaymessage:displaydelegate: state:

Method for rendering a specified message on client side. It’s called from main thread.

But when overriding
FIRInAppMessagingDisplay#displayMessage:displayDelegate: on a custom message display component, the method will be invoked on a background thread.
Could you please update the behavior to match the documentation - or reverse?
Thanks! :)
@google-oss-bot

This comment has been minimized.

Sign in to view
@airspeed airspeed changed the title Documentation: update references to FIRInAppMessagingRendering FIRInAppMessagingDisplay: protocol method called from a background thread Jul 3, 2020
@paulb777 paulb777 added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Jul 4, 2020
@MeghaB MeghaB added the Docs label Jul 6, 2020
@morganchen12 morganchen12 self-assigned this Jul 6, 2020
@morganchen12 morganchen12 mentioned this issue Jul 6, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morganchen12 morganchen12

Labels
api: inappmessaging Firebase In App Messaging Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inaccurate doc comment firebase/firebase-ios-sdk
5 participants
@paulb777 @MeghaB @airspeed @morganchen12 @google-oss-bot