Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GDT and GDTCCT to a single pod #5902

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Consolidate GDT and GDTCCT to a single pod #5902

merged 6 commits into from
Jun 24, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 24, 2020 •
edited

Consolidate GoogleDataTransportCCTSupport into GoogleDataTransport and remove its references from the repo.

Comments out a test assert that also seems broken on master.

Doesn't address the CoreDiagnostics test failures that exist on master.

mikehaney24
mikehaney24 suggested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@mikehaney24 mikehaney24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good:

  • Project generation looks good
  • File structure looks good

The bad:

  • I can't build the test apps because of a module issue:
    image

@paulb777
Copy link
Member Author

@mikehaney24 pod gen of multiple platforms is problematic for CocoaPods and Xcode. It can generate differences across pod lint and Xcode versions. I updated the generate_porject.sh script to generate a single platform on an option with iOS the default.

@paulb777
Copy link
Member Author

@mikehaney24 Good catch on the script name. Fixed.

Hmm, the pod lib lint tests were failing for me because of the different module name associated with the single platform runs. This change makes pod gen and pod lib lint consistent. ./generate_project.sh macos will generate a mac project that can be tested separate from pod lib lint.

@paulb777 paulb777 merged commit e03a8d9 into master Jun 24, 2020
@paulb777 paulb777 deleted the pb-consolidate-gdt branch June 24, 2020 21:09
granluo pushed a commit that referenced this pull request Jul 7, 2020
@paulb777 @granluo
Consolidate GDT and GDTCCT to a single pod (#5902)
9a77497
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikehaney24 mikehaney24 mikehaney24 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Assignees
No one assigned
Labels
api: auth api: core api: firestore api: inappmessaging Firebase In App Messaging api: messaging cla: yes GoogleDataTransport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulb777 @mikehaney24 @maksymmalyhin @googlebot @google-oss-bot