Use preserve_paths instead of CocoaPods private #5758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Closed
510bd08
to
fb95b88
Compare
ryanwilson
approved these changes
Jun 9, 2020
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
One minor request - it may be helpful for future readers to have a comment at the top of this file specifying why it exists and why it's necessary.
|
I run into this error FirebaseCore/Sources/Private/FirebaseCoreInternal.h not find Flutter project |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize and simplify internal FirebaseCore imports. Note the fast-follow #5760 changes the
preserve_pathtosource_filesso that the headers show up in generated Xcode projects.FirebaseCore/Sources/Private/FirebaseCoreInternal.hinstead of any specific header files.__has_includetest so old IID used by FIS tests can find the Core private headers since the old podspec doesn't know how to find repo-relative headers. Also necessary for the latest Core to work with other old Firebase 6.x pods.FIRErrorCodeConfigFailed#if __cplusplusfor public header imports from the Core Firebase-internal headers since Objective C++ modules don't work for unqualified public header names. I changed this back to a#if SWIFT_PACKAGEcheck in Migrate from interop pods to source_files header access #5760 since other issues came up with public header references from private headers there - so this can mostly be disregarded.The first commit is large, but purely the mechanical change of all of the import changes (from a small Swift script). The interesting changes are in the commits that follow.
I tested with the
private_headersremoved from the FirebaseCore podspec. I'm restored the private_headers before merging to avoid a breaking change before 7.0.